test: simplify test_agent_waits_for_messages_when_predecessor_is_blocked#10744
Merged
test: simplify test_agent_waits_for_messages_when_predecessor_is_blocked#10744
test_agent_waits_for_messages_when_predecessor_is_blocked#10744Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
anakin87
changed the title
test_agent_waits_for_messages_when_predecessor_is_blocked
Collaborator
Pull Request Test Coverage Report for Build 22752304150Details
💛 - Coveralls |
anakin87
added
the
ignore-for-release-notes
bogdankostic
approved these changes
Mar 6, 2026
Contributor
bogdankostic
left a comment
bogdankostic
left a comment
There was a problem hiding this comment.
Thanks @anakin87, I agree that the test is now easier to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
When working on #10718, I noticed this recently introduced test (in #10734).
It took me some time to understand what bug it was trying to prevent. To make this easier for future readers, I tried to simplify it a bit.
Proposed Changes:
How did you test it?
CI. Also tested that this is equivalent to the original test: if we go back to commit 6626f2c (before merging #10734), it fails as expected.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.