fix: resolve in-place dataclass mutations#10692
Closed
Anandesh-Sharma wants to merge 1 commit intodeepset-ai:mainfrom
Closed
fix: resolve in-place dataclass mutations#10692Anandesh-Sharma wants to merge 1 commit intodeepset-ai:mainfrom
Anandesh-Sharma wants to merge 1 commit intodeepset-ai:mainfrom
Conversation
Replace direct attribute mutations on dataclass instances (doc.score = x, stream.mime_type = y, etc.) with dataclasses.replace() calls across 12 source files. This resolves the deprecation warnings introduced by the dataclass mutation detection added in PR deepset-ai#10650. Fixes deepset-ai#10659 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@Anandesh-Sharma is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Member
|
@Anandesh-Sharma could you please sign the CLA? |
Member
|
Superseded by #10702 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doc.score = x,stream.mime_type = y, etc.) withdataclasses.replace()across 12 source filesRelated Issue
Fixes #10659
Changes by file
chat_prompt_builder.pyrendered_message._content = [...]pipeline.pypipeline_snapshot.agent_snapshot = ...,pipeline_snapshot.break_point = ...file_to_image.pybytestream.mime_type = ...llm_metadata_extractor.pydoc_copy.content = contentlink_content.pystream.mime_type = ...(3 places: sync run, sync multi-url, async)document_joiner.pydoc.score = ...(3 methods: _merge, _reciprocal_rank_fusion, _distribution_based_rank_fusion)hugging_face_tei.pydoc_copy.score = ...meta_field.pydocument.score = ...sentence_transformers_similarity.pydocument.score = scoretransformers_similarity.pydeduplicated_documents[i].score = ...extractive.pyanswer.query = ...,answer.meta = {},answer.meta.update(...)in_memory/document_store.pydoc.embedding = NoneTest plan
🤖 Generated with Claude Code