Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(pt/pt_expt): O(N) vesin neighbor list for Python/ASE inference #5486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pt/pt_expt): O(N) vesin neighbor list for Python/ASE inference #5486
Changes from all commits
c3199eb042ae50b209472fff545e2edaa0b237fd11File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don’t silently ignore an explicit
neighbor_listin the pt backend.This constructor still exposes
neighbor_list, but the value is never stored or consulted before Line 297 enables vesin. Withdeepmd.calculator.DPnow forwarding both knobs,DP(..., neighbor_list=..., nlist_backend="vesin")will take the vesin path instead of the caller-provided list and never warn. Please either wire the ASE list through here or fail fast whenneighbor_listis non-None; at minimum,"vesin"should reject that combination.Also applies to: 260-299
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For frozen
.pthmodels that carrydata_modifier.pth, this path now bypassesModelWrapperby calling the bareDefaultmodel, so the modifier contribution that the native path adds inModelWrapper.forwardis silently dropped whenevernlist_backendresolves toauto/vesin. In those deployments (e.g. models with an added correction term), energies/forces/virials from the default inference path will be missing the modifier rather than matching the existing native results; either apply the modifier afterforward_common_loweror keep such models on the native wrapper path.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Block vesin for hessian models here too.
Line 159 only treats spin as unsupported, but this backend still exposes hessian outputs via
OutputVariableCategory.DERV_R_DERV_R. A hessian archive can therefore select the vesin path here instead of failing fast, which breaks the advertised backend contract and risks incorrect second-derivative results.Suggested fix
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.