-
Notifications
You must be signed in to change notification settings - Fork 584
fix(jax): setattr case_embd
#5104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`case_embd` was supported but the JAX backend was not touched.
📝 WalkthroughWalkthroughAdded "case_embd" to fitting attribute conversion logic for JAX and strict Array API paths, and updated a TensorFlow test module to reset the default graph before enabling eager execution. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a missing attribute handler for case_embd in the JAX backend. The case_embd attribute was already supported in PyTorch and Paddle backends but was not being properly handled in the JAX backend's setattr_for_general_fitting function.
- Added
case_embdto the set of attributes that are converted to JAX arrays in the fitting module
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #5104 +/- ##
=======================================
Coverage 82.14% 82.14%
=======================================
Files 709 709
Lines 72458 72468 +10
Branches 3615 3615
=======================================
+ Hits 59520 59530 +10
+ Misses 11776 11775 -1
- Partials 1162 1163 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
`case_embd` was supported but the JAX backend was not touched. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **Bug Fixes** * Improved parameter handling in the fitting module to properly support the `case_embd` parameter, ensuring it receives consistent treatment and array conversion as other fitting parameters. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
This reverts commit acc2eb0.
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
case_embdwas supported but the JAX backend was not touched.Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.