Refactor/Add convergence-rate-based adaptive frequency for BPCG subspace diagonalization#7441
Open
Missing-Hex wants to merge 3 commits into
Open
Refactor/Add convergence-rate-based adaptive frequency for BPCG subspace diagonalization#7441Missing-Hex wants to merge 3 commits into
Missing-Hex wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a convergence-rate-based adaptive frequency mechanism to the BPCG diagonalization method. The subspace diagonalization call frequency now dynamically adjusts based on the actual convergence state, building on top of the existing problem-size-based frequency.
Key Idea
Track historical error changes, compute convergence rate every 2 CG steps, and adjust frequency accordingly:
Convergence Rate Definition
Two-Level Frequency Control
n_band × n_basis)Final frequency = baseline_freq ± adaptive_adjustment (clamped to [1, nline])
Code Changes
bpcg_kernel_op.h/cppcompute_convergence_rate()andcompute_adaptive_freq()diago_bpcg.hupdate_adaptive_freq()diago_bpcg.cppBenefits
Example Usage
The adaptive frequency automatically responds to convergence behavior without any user configuration.