Skip to content

[Fix] 020-twilio-media-streams-node — handle missing ffmpeg in test #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

[Fix] 020-twilio-media-streams-node — handle missing ffmpeg in test #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions examples/020-twilio-media-streams-node/tests/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,21 @@ const TMP_MULAW = '/tmp/twilio_test.mulaw';
// We use 320 to match Twilio's actual observed frame size.
const CHUNK_SIZE = 320;

// Convert a known audio file to μ-law 8 kHz using ffmpeg.
// ffmpeg is pre-installed on all GitHub Actions ubuntu runners.
function ensureFfmpeg() {
try {
execSync('which ffmpeg', { stdio: 'pipe' });
} catch {
console.log('ffmpeg not found — installing via apt-get...');
execSync('sudo apt-get update -qq && sudo apt-get install -qq -y ffmpeg', {
stdio: 'pipe',
timeout: 60_000,
});
}
}

function prepareMulawAudio() {
ensureFfmpeg();

console.log('Downloading test audio...');
execSync(`curl -s -L -o "${TMP_WAV}" "${AUDIO_URL}"`, { stdio: 'pipe' });

Expand All @@ -44,8 +56,11 @@ function prepareMulawAudio() {
'-ar', '8000', '-ac', '1', '-f', 'mulaw', TMP_MULAW,
], { stdio: 'pipe' });

if (result.error) {
throw new Error(`ffmpeg spawn error: ${result.error.message}`);
}
if (result.status !== 0) {
throw new Error(`ffmpeg failed: ${result.stderr.toString().slice(0, 300)}`);
throw new Error(`ffmpeg failed: ${(result.stderr || Buffer.alloc(0)).toString().slice(0, 300)}`);
}

const audio = fs.readFileSync(TMP_MULAW);
Expand Down