fix: typo in serialization for Container::None#122
Merged
lukeocodes merged 1 commit intodeepgram:mainfrom Feb 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical serialization bug in the Container enum where Container::None was being serialized as "nonne" instead of "none", which would cause API errors when this option is used.
Changes:
- Corrected typo in Container::None serialization from "nonne" to "none"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lukeocodes
changed the title
Member
|
lol yeh we need this fix |
lukeocodes
approved these changes
Feb 26, 2026
lukeocodes
added a commit
that referenced
this pull request
Feb 26, 2026
## Summary - **fix**: `Container::None` serialization typo (`"nonne"` → `"none"`) causing 400 errors on TTS raw audio requests (#122) - **fix**: missing `User-Agent` header on WebSocket handshake requests, breaking AWS WAF compatibility (#133) - **fix**: broken Discord badge in README (#135) - **fix**: Flux WebSocket now handles unknown message types gracefully instead of producing stream-breaking `JsonError`s (#141) - `FluxResponse::Unknown(serde_json::Value)` preserves the raw JSON for inspection/logging - `TurnEvent::Unknown` catches unrecognized event strings via `#[serde(other)]` - Non-breaking: both enums are `#[non_exhaustive]` ## Changes - Bump version to 0.9.1 - Update CHANGELOG with 0.9.1 entries - Lock 0.9.0 changelog link to `0.9.0` tag ## Test plan - [x] Verified `Container::None` serialization bug with unit test and e2e against Deepgram API - [x] Confirmed fix produces `container=none` and API returns audio successfully - [x] Mock WebSocket tests verify unknown messages don't break the Flux stream - [x] E2e test streams real audio to Deepgram Flux API successfully - [x] CI passes on this branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Container::NoneTypes of changes
Checklist