Open
Conversation
c001d3c to
805682a
Compare
faf72ba to
83a26f4
Compare
Added 'Additional*' fields in a backward-compatible way. Also split the evoting/struct.go to a evoting/proto.go for updating the messages in the evoting frontend.
Put more methods in evoting/lib/container.go Prepared usage of multiple points per vote
Showing all elections Allow voting if the private key is known
83a26f4 to
1d37c7e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








What this PR does
For a new election at EPFL there will be more than 8 candidates. This is a problem, as currently all
choices are stored as
datain aned25519Point. But as thisPointonly takes 24 bits of data,we cannot store easily more than 9 choices.
To allow for more than 9 candidates, each
Ballot,Mix, andPartialwill haveAdditional*fieldsto hold the additional choices.
As these fields are slices, and added to the end of the structures, and thus to the end of the protobuf definition,
it should be backward-compatible.
To make sure we don't add security problems, we also do:
Additionalfields in theBallotas are maximally possible, to avoid leaking for how many candidates a person votedshuffle/sequences.goif there are more than 9 candidates🙅 Friendly checklist:
xerrors.Errorfand the%vverb.