fix(auth): add auth + org ownership check to public events endpoint#3040
Open
0xcucumbersalad wants to merge 2 commits intodecocms:mainfrom
Open
fix(auth): add auth + org ownership check to public events endpoint#30400xcucumbersalad wants to merge 2 commits intodecocms:mainfrom
0xcucumbersalad wants to merge 2 commits intodecocms:mainfrom
Conversation
The POST /org/:organizationId/events/:type endpoint had no authentication gate, allowing unauthenticated cross-tenant event injection including persistent cron events. Adds the same auth + org ownership pattern used by the adjacent watch endpoint. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
🧪 BenchmarkShould we run the Virtual MCP strategy benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsSuggested: Patch ( React with an emoji to override the release type:
Current version:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /org/:organizationId/events/:typehad zero authentication — any unauthenticated request could inject events (including persistent cron events) into any organization's event bus/org/:organizationId/watchendpointTest plan
bun test apps/mesh/src/api/routes/public-events.test.ts— 5/5 passbun run lint— passesbun run fmt— passes🤖 Generated with Claude Code
Summary by cubic
Locks down
POST /org/:organizationId/events/:typewith auth and org-ownership checks to stop unauthenticated or cross-tenant event injection (AUTHZ-VULN-05). Returns 401 when unauthenticated and 403 when the org does not match.:organizationIdto the caller’s org (403 on mismatch)./org/:organizationId/watch.Written for commit 6d8ff9d. Summary will update on new commits.