fix(core): run firmware upgrade migration only for running vmi

[danilrwx]

Description

Adjust firmware update behavior to avoid signaling outdated firmware for non-running instances and keep workload-updater migration flow driven by VM condition + virt-controller readiness.

Functional changes

1. pkg/controller/vm/internal/firmware.go

   • FirmwareUpToDate=False is now set only when KVVMI is Running and launcher image differs.
   • For non-running KVVMI phases (Succeeded, Failed, etc.) the firmware condition is not raised.

2. pkg/controller/workload-updater/internal/handler/firmware.go

   • Handler flow now relies on:
     • needUpdate(vm) (VM condition),
     • isVirtControllerUpToDate(...).
   • Obsolete KVVMI-specific gate in this handler path is removed.

Test changes

• Updated VM firmware handler tests (pkg/controller/vm/internal/firmware_test.go) with explicit non-running KVVMI cases (Succeeded, Failed).
• Updated workload-updater firmware tests (pkg/controller/workload-updater/internal/handler/firmware_test.go) to match current handler contract and removed obsolete KVVMI-centric checks.
• Added/kept branch tests for launcher image parsing and readiness checks.

Validation:

• go test ./pkg/controller/vm/internal/...
• go test ./pkg/controller/workload-updater/internal/handler/...
• task lint:go

All pass.

Why do we need it, and what problem does it solve?

Previously, firmware-outdated condition could stay active for non-running instances, which was noisy and could trigger misleading update flows.

With this change:

• condition semantics are aligned with actionable state (running workload only),
• migration decisions stay consistent with VM condition and controller readiness,
• test suite matches current behavior and guards regressions.

What is the expected result?

1. For non-running KVVMI phases (Succeeded, Failed), VM should not expose FirmwareUpToDate=False due to image mismatch.
2. For running KVVMI with image mismatch, VM should expose FirmwareUpToDate=False.
3. Workload-updater triggers migration only when firmware update is needed and virt-controller is ready/up-to-date.

Checklist

• The code is covered by unit tests.
• e2e tests passed.
• Documentation updated according to the changes.
• Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: core
type: fix
summary: "Set firmware outdated condition only for running VM instances and align firmware workload-updater checks with current condition-driven flow."
impact_level: low