fix(agent): load dm_snapshot when storage-foundation is enabled#303
Merged
Conversation
The thin-volumes-enabler init container only added dm_snapshot to the modprobe args when the snapshot-controller module was enabled. Clusters that provide snapshot functionality through the storage-foundation module (the extended VolumeSnapshot fork) left dm_snapshot unloaded, so LVM snapshot creation failed with "Required device-mapper target(s) not detected in your kernel". Load dm_snapshot when either snapshot-controller or storage-foundation is enabled. Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
duckhawk
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The thin-volumes-enabler init container only added dm_snapshot to the modprobe args when the snapshot-controller module was enabled. Clusters that provide snapshot functionality through the storage-foundation module (the extended VolumeSnapshot fork) left dm_snapshot unloaded, so LVM snapshot creation failed with "Required device-mapper target(s) not detected in your kernel". Load dm_snapshot when either snapshot-controller or storage-foundation is enabled.
Why do we need it, and what problem does it solve?
We need to enable dm_snapshot while only storage-foundation enabled
What is the expected result?
Correct module work
Checklist