Skip to content

Conversation

@name212
Copy link
Member

@name212 name212 commented Jan 12, 2026

deprecate *Ln methods in logger

Remove next methods from retry.Params:

WithName(n string) Params`
WithAttempts(attempts int) Params
WithWait(wait time.Duration) Params
WithLogger(logger log.Logger) Params

Now retry.Params is readonly now. It needs to prevent change in usage. For example we pass to function Params and rewrite params in original object before run loop. It it incorrect, to prevent it we do Params readonly

Signed-off-by: Nikolay Mitrofanov <nikolay.mitrofanov@flant.com>
@name212 name212 changed the title Readonly retry.Params and deprecate *Ln func in logger Readonly retry.Params and deprecate *Ln methods in logger Jan 12, 2026
@name212 name212 merged commit f6b6f68 into main Jan 12, 2026
3 checks passed
@name212 name212 deleted the change-retry-params-and-deprecations branch January 12, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants