Skip to content

build: latest nightly changed the type#20

Closed
tricktux wants to merge 2 commits intodeckarep:mainfrom
tricktux:main
Closed

build: latest nightly changed the type#20
tricktux wants to merge 2 commits intodeckarep:mainfrom
tricktux:main

Conversation

@tricktux
Copy link

@tricktux tricktux commented Apr 4, 2025

tested on zig version: 0.14.0-dev.3086+b3c63e5de

@deckarep
Copy link
Owner

deckarep commented Apr 4, 2025

Thanks for the heads up on this. Looks like it breaks the build which I imagine is because the Zig CI workflow is likely still pinned to the 0.14.0 release.

Since this is a bleeding edge change I’m not sure I will just yet merge it because I’d prefer to keep this lib on a stable version of Zig unless there’s a way we can take the change while still keeping a working version/build for the Zig 0.14.0 release.

I welcome your thoughts here.

@tricktux
Copy link
Author

tricktux commented Apr 5, 2025

Thank you for considering it.

The change is so trivial that I agree with you. No need to break prob 90% of the folks out there.

I can use the pull request branch.

I leave to your consideration to close the pull request.

Thanks for a great lib!

@deckarep
Copy link
Owner

deckarep commented Apr 5, 2025

Absolutely! And I’ll leave it open for a while since we will need this eventually. Then I’ll merge it.

I appreciate any and all contributions and thanks again! If you find other ways to improve this lib please let me know or send another PR my way.

@deckarep
Copy link
Owner

deckarep commented Nov 29, 2025

I know this has been open for awhile, does it make sense to merge at this point?

Uh oh, test failing

@tricktux
Copy link
Author

They regressed again. Literal enums seem to be the way again..... 🤷🏻‍♂️ 😄

@tricktux tricktux closed this Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants