Fix handflow FlowReplace bitfields #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
...and at the end of the day, it didn't fix my problems after all, but hey at least this code is still fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several configuration bits for serial (specified here) that are incorrectly applied to the
ControlHandShakemember, when in fact they belong toFlowReplace. I have had a real situation where this causes a hooked program to never receive any bytes from serial.I also brought in 2 bits that existed in
my_GetCommStatebut notmy_SetCommState.There are still ~4 missing bits spread across both fields, but they're obscure so I'm not fussed.