Merged
Conversation
… 20req/10s global) MMR endpoints had rate limits documented in OpenAPI but not enforced in code. Added apply_limits() calls with shared "mmr" bucket across all 6 endpoints. https://claude.ai/code/session_01QYY6jEz4bRkMr9s7xsM1p7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements rate limiting across all MMR-related API endpoints to protect against abuse and ensure fair resource usage. This change adds rate limit checks to 6 endpoints in the MMR module using a configurable quota system with IP-based, key-based, and global limits.
The rate limits are applied consistently across all endpoints:
Additionally, the API documentation has been updated to reflect the new rate limit values (previously listed as 100req/s with no key/global limits).
Related Issue
Type of Change
How Has This Been Tested?
Checklist
Additional Notes
The rate limiting is applied at the handler level for the following endpoints:
GET /v1/players/mmr(batch MMR)GET /v1/players/mmr/hero(batch hero MMR)GET /v1/players/mmr/distribution(MMR distribution)GET /v1/players/mmr/distribution/hero/{hero_id}(hero MMR distribution)GET /v1/players/mmr/{account_id}(MMR history)GET /v1/players/mmr/{account_id}/hero/{hero_id}(hero MMR history)https://claude.ai/code/session_01QYY6jEz4bRkMr9s7xsM1p7