Skip to content

Fix dotnet doc error check and remove debugging notes #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tameware wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix dotnet doc error check and remove debugging notes #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb0f74c
Fix dotnet doc error check and remove debugging notes
tameware Jul 4, 2026
ca0e80d
Removed second stray comment.
tameware Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/dotnet_interface.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,10 +367,6 @@ public void sample()
throw new InvalidOperationException(error);
}

if (!(int)ctx.SolveBoard(deal, -1, 1, 0, out FutureTricks fut))
throw new InvalidOperationException("DDS_Core failed to solve the board.");


...

var ddTableDeal = new() {Cards = hands };
Expand Down
4 changes: 1 addition & 3 deletions dotnet/DDS_Core/DDS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ public int SolveAllBoards( in BoardsPBN boards
, out SolvedBoards solved)
{
solved = default;
//Note: To step into c++ code you must set a break in c++?
var rc = DdsNative.SolveAllBoards( boards
, out solved);

Expand All @@ -189,7 +188,6 @@ public int SolveAllBoards( in Boards bop
{
solved = default;

//Note: To step into c++ code you must set a break in c++?
var rc = DdsNative.SolveAllBoardsBin( bop
, out solved);
Comment thread
tameware marked this conversation as resolved.

Expand Down Expand Up @@ -638,4 +636,4 @@ private static void ThrowIfError(in int result, in string functionName)
throw new InvalidOperationException($"{functionName} failed with code {result}: {result.GetRCErrorMessage()}");
}
#endregion
}
}
Loading