Fix small performance regression versus v2.9

.bazelrc

@@ -19,38 +19,44 @@ build:linux --host_cxxopt=-std=c++20
 build:opt --compilation_mode=opt
 
 # AddressSanitizer configuration
-# Usage:
-#   Linux: bazel test --config=asan //path:target
-#   macOS: bazel test --config=asan --config=asan_macos //path:target
+# Usage: bazel test --config=asan //path:target
+# macOS uses the Xcode toolchain (build:asan_macos). See docs/BUILD_SYSTEM.md
+# ("AddressSanitizer and ThreadSanitizer (macOS)") for clang/Xcode version coupling.
+build:asan --config=asan_macos
+
 build:asan --copt=-fsanitize=address
 build:asan --linkopt=-fsanitize=address
+# Undefine _FORTIFY_SOURCE; it conflicts with ASAN instrumentation.
+build:asan --copt=-U_FORTIFY_SOURCE
 build:asan --strip=never
 build:asan --features=dbg
 build:asan --compilation_mode=dbg
 test:asan --test_timeout=120,300,900,3600
 
-# GoogleTest headers can trigger conversion warnings on Clang; suppress for tests.
+# GoogleTest headers can trigger conversion warnings on Clang; suppress them.
+# Scoped to `build` (not `test`) so the suppression also applies to plain
+# `bazel build` of test targets and tooling that compiles GoogleTest, not just
+# `bazel test`. The `build` config is inherited by `test`, `run`, etc.
 # On Linux, use -Wno-conversion for portability when the system compiler is GCC.
-test:macos --cxxopt=-Wno-character-conversion
-test:linux --cxxopt=-Wno-conversion
-# macOS-specific AddressSanitizer runtime lookup configuration.
-# The LLVM toolchain bundles the ASAN runtime. On macOS tests run from the
-# runfiles tree, so use @loader_path-based rpaths that walk back to execroot
-# and then into external/toolchains_llvm...
-# Keep the clang major version in these paths aligned with darwin-aarch64
-# in MODULE.bazel.
-# Bazel test binaries live at different depths under bazel-out/.../bin.
-# Provide a small set of distinct @loader_path traversals to reach
-# execroot/_main/external from common test binary depths.
-build:asan_macos --linkopt=-Wl,-rpath,@loader_path/../../../../../external/toolchains_llvm++llvm+llvm_toolchain_llvm/lib/clang/20/lib/darwin
-build:asan_macos --linkopt=-Wl,-rpath,@loader_path/../../../../../../external/toolchains_llvm++llvm+llvm_toolchain_llvm/lib/clang/20/lib/darwin
-build:asan_macos --linkopt=-Wl,-rpath,@loader_path/../../../../../../../external/toolchains_llvm++llvm+llvm_toolchain_llvm/lib/clang/20/lib/darwin
-build:asan_macos --linkopt=-Wl,-rpath,@loader_path/../../../../../../../../external/toolchains_llvm++llvm+llvm_toolchain_llvm/lib/clang/20/lib/darwin
+build:macos --cxxopt=-Wno-character-conversion
+build:linux --cxxopt=-Wno-conversion
+# macOS AddressSanitizer must use the Xcode compiler/runtime. LLVM-instrumented
+# binaries hang with LLVM's ASAN dylib and abort with Xcode's (version mismatch).
+# Chained from build:asan; Apple toolchains do not match on Linux and are ignored.
+build:asan_macos --extra_toolchains=@local_config_apple_cc_toolchains//:all
+build:asan_macos --copt=-Wno-macro-redefined
 
 # ThreadSanitizer configuration
 # Usage: bazel test --config=tsan //path:target
+# macOS loads Xcode's compiler-rt via build:tsan_macos (rpath uses clang/N).
+# Keep N aligned with MODULE.bazel llvm_versions and installed Xcode; see
+# docs/BUILD_SYSTEM.md ("AddressSanitizer and ThreadSanitizer (macOS)").
+build:tsan --config=tsan_macos
 build:tsan --copt=-fsanitize=thread
 build:tsan --linkopt=-fsanitize=thread
 build:tsan --strip=never
 build:tsan --features=dbg
 build:tsan --compilation_mode=dbg
+test:tsan --test_timeout=120,300,900,3600
+# Hardcoded rpath: .../lib/clang/21/... must match MODULE.bazel llvm major and Xcode.
+build:tsan_macos --linkopt=-Wl,-rpath,/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/21/lib/darwin

.github/copilot-instructions.md

@@ -41,8 +41,8 @@ bazel build -c opt //...
 # Build with debug symbols
 bazel build -c dbg //...
 
-# Build with specific flags (example: enable ASAN)
-bazel build --define=asan=true //...
+# Build with AddressSanitizer (see .bazelrc build:asan and docs/BUILD_SYSTEM.md)
+bazel build --config=asan //...
 ```
 
 ### Build Time Expectations
@@ -200,9 +200,9 @@ If CI fails:
 
 Before finalizing changes, optionally run:
 ```bash
-# Check for memory leaks (Linux only)
-bazel build --define=asan=true //...
-bazel test --define=asan=true //...
+# Check for memory leaks (see docs/BUILD_SYSTEM.md for macOS/Linux notes)
+bazel build --config=asan //...
+bazel test --config=asan //...
 
 # Performance test with real hands
 bazel build //library/tests:dtest
@@ -276,7 +276,7 @@ bazel build //library/tests:dtest
 
 **Problem**: Tests fail with "Segmentation fault"
 - **Cause**: Usually memory management bug or uninitialized variable
-- **Fix**: Run with ASAN: `bazel test --define=asan=true //library/tests:failing_test`
+- **Fix**: Run with ASAN: `bazel test --config=asan //library/tests:failing_test`
 
 **Problem**: Tests fail with different results than expected
 - **Cause**: Possibly heuristic sorting or transposition table issues

.github/instructions/git.instructions.md

@@ -21,6 +21,6 @@ alwaysApply: false
 2. **Make changes** locally.  
 3. **Commit** with a clear message.  
 4. **Push** the branch.  
-5. **Open a PR** via the `github` MCP server (see `github.instructions.md`).  
+5. **Open a PR** via the GitHub CLI (`gh`).
 
 ---

.github/instructions/github.instructions.md

@@ -7,7 +7,6 @@ alwaysApply: false
 
 ## Overview
 This project uses GitHub as its primary version control and collaboration platform. All code contributions, fixes, and features must go through a pull request (PR) workflow.
-You have access to an MCP server named **`github`** (running `mcp-github`) which can create branches, push commits, and open PRs directly from the Continue.dev environment. See `.vscode/mcp.json` for configuration.
 
 ## Branching Strategy
 - **Default branch:** `main`
@@ -29,28 +28,17 @@ You have access to an MCP server named **`github`** (running `mcp-github`) which
    - CI build
    - All unit and integration tests
    - Any lint/format checks
-5. Small PRs are preferred — keep them focused on one logical change.
+5. Small PRs are preferred — keep each focused on one logical change.
 
 ## Tooling
-Use the **`github`** MCP server (configured in `.vscode/mcp.json`) to:
+Use `git` for local version control, and the GitHub CLI (`gh`) for GitHub operations:
    - Create branches
    - Commit and push changes
    - Open pull requests
    - Check PR status
-## Example MCP Server Commands
-You can instruct Continue.dev to:
-- `Use the github MCP server to create a new branch called fix/memory-leak`
-- `Push the current branch and open a pull request titled "Fix memory leak in cache manager"`
-- `List open pull requests for this repo`
-- `Merge PR #45 after approval`
 
 ## Automation
-- CI/CD runs automatically for all PRs.
+- CI runs automatically for all PRs.
 - Approved PRs can be merged by maintainers.
-- Use **squash merging** to keep history clean.
 
-## Notes for Continue.dev
-- You are allowed to automate branch creation and PR submission using the `github` MCP server.
-- If multiple PRs are required, ensure each is isolated to its own branch.
-- You may request human review before merging.
 ```

.github/workflows/ci_linux.yml

@@ -9,6 +9,7 @@ on:
 jobs:
   build_and_test:
     runs-on: ubuntu-latest
+    timeout-minutes: 20
     steps:
       # 1️⃣ Checkout the repository
       - name: Checkout repository
@@ -31,3 +32,61 @@ jobs:
       # 6️⃣ Run all tests (including Python)
       - name: Run all tests
         run: bazel test --verbose_failures //...
+
+      # 7️⃣ Upload test logs
+      - name: Upload test logs - Linux
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: bazel-test-logs-linux
+          path: bazel-testlogs/
+          if-no-files-found: ignore
+          retention-days: 30
+
+  asan:
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v6
+
+      - name: Setup Bazelisk
+        uses: bazel-contrib/setup-bazel@0.19.0
+        with:
+          bazelisk-version: "1.29.0"
+
+      - name: Run tests (AddressSanitizer)
+        run: bazel test --config=asan --verbose_failures --test_output=errors //library/tests/...
+
+      - name: Upload ASAN test logs
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: bazel-test-logs-linux-asan
+          path: bazel-testlogs/
+          if-no-files-found: ignore
+          retention-days: 30
+
+  tsan:
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v6
+
+      - name: Setup Bazelisk
+        uses: bazel-contrib/setup-bazel@0.19.0
+        with:
+          bazelisk-version: "1.29.0"
+
+      - name: Run system tests (ThreadSanitizer)
+        run: bazel test --config=tsan --verbose_failures --test_output=errors //library/tests/system/...
+
+      - name: Upload TSAN test logs
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: bazel-test-logs-linux-tsan
+          path: bazel-testlogs/
+          if-no-files-found: ignore
+          retention-days: 30

.github/workflows/ci_macos.yml

@@ -8,6 +8,7 @@ on:
 jobs:
   build_and_test:
     runs-on: macos-26
+    timeout-minutes: 20
     steps:
       # Checkout the repository
       - name: Checkout repository
@@ -30,3 +31,40 @@ jobs:
       # Run all tests (including Python)
       - name: Run all tests
         run: bazelisk test --verbose_failures //...
+
+      # Upload test logs
+      - name: Upload test logs - macOS
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: bazel-test-logs-macos
+          path: bazel-testlogs/
+          if-no-files-found: ignore
+          retention-days: 30
+
+  sanitizers:
+    runs-on: macos-26
+    timeout-minutes: 20
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v6
+
+      - name: Setup Bazelisk
+        uses: bazel-contrib/setup-bazel@0.19.0
+        with:
+          bazelisk-version: "1.29.0"
+
+      - name: Run system tests (AddressSanitizer)
+        run: bazelisk test --config=asan --verbose_failures --test_output=errors //library/tests/system/...
+
+      - name: Run system tests (ThreadSanitizer)
+        run: bazelisk test --config=tsan --verbose_failures --test_output=errors //library/tests/system/...
+
+      - name: Upload sanitizer test logs
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: bazel-test-logs-macos-sanitizers
+          path: bazel-testlogs/
+          if-no-files-found: ignore
+          retention-days: 30

.github/workflows/ci_wasm.yml

@@ -9,6 +9,7 @@ on:
 jobs:
   build_and_test:
     runs-on: ubuntu-latest
+    timeout-minutes: 20
     steps:
       # 1️⃣ Checkout the repository
       - name: Checkout repository
@@ -29,4 +30,14 @@ jobs:
 
       # 4️⃣ Smoke test: run solve_board under Node.js — pass if it does not crash
       - name: Smoke test solve_board_wasm
-        run: node bazel-bin/examples/wasm/solve_board.js
+        run: node bazel-bin/examples/wasm/solve_board.js
+
+      # 5️⃣ Upload test logs
+      - name: Upload test logs - WASM
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: bazel-test-logs-wasm
+          path: bazel-testlogs/
+          if-no-files-found: ignore
+          retention-days: 30

.github/workflows/ci_windows.yml

@@ -8,6 +8,7 @@ on:
 jobs:
   build_and_test:
     runs-on: windows-latest
+    timeout-minutes: 20
     steps:
       # Checkout the repository
       - name: Checkout repository
@@ -26,3 +27,13 @@ jobs:
       # Run all tests (including Python)
       - name: Run all tests
         run: bazel test --verbose_failures //...
+
+      # Upload test logs
+      - name: Upload test logs - Windows
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: bazel-test-logs-windows
+          path: bazel-testlogs/
+          if-no-files-found: ignore
+          retention-days: 30

.gitignore

@@ -5,13 +5,18 @@
 !.vscode/mcp.json
 !.vscode/tasks.json
 
+# Ignore Cursor or VS Code workspace files
+*.code-workspace
+
 # Ignore Visual Studio directory and files
 .vs
 #*/.vs/*
 #*.vsidx
 *.vcxproj.user
 Build/bin
 Build/int
+obj
+.cr
 
 # Prerequisites
 *.d
@@ -103,3 +108,5 @@ doxygen_output/
 .cce/
 # Claude Code local settings written by cce init
 .claude/settings.local.json
+
+/dotnet/DDS_Core/.github/copilot-instructions.md

BUILD.bazel

@@ -56,6 +56,12 @@ config_setting(
     define_values = {"scheduler": "true"},
 )
 
+# Enable DDS_AB_STATS via --define=ab_stats=true
+config_setting(
+    name = "ab_stats",
+    define_values = {"ab_stats": "true"},
+)
+
 # Enable DDS_TT_CONTEXT_OWNERSHIP via --define=tt_context_ownership=true
 config_setting(
     name = "tt_context_ownership",
@@ -68,12 +74,6 @@ config_setting(
     define_values = {"tt_reset_debug": "true"},
 )
 
-# Enable AddressSanitizer via --define=asan=true
-config_setting(
-    name = "asan",
-    define_values = {"asan": "true"},
-)
-
 # Matches cc_* targets built under the wasm_cc_binary platform transition.
 # Use platform constraints (not deprecated `cpu` select) so this works
 # consistently across host OSes, including Windows.
@@ -93,6 +93,11 @@ genrule(
     outs = ["doxygen_docs.zip"],
     cmd = """
       set -e
+      case "$$(uname -s)" in
+        Darwin)  PATH="/opt/homebrew/bin:/usr/local/bin:$$PATH" ;;
+        Linux)   PATH="/usr/local/bin:$$PATH" ;;
+        MINGW*|MSYS*|CYGWIN*) PATH="/usr/bin:/usr/local/bin:$$PATH" ;;
+      esac
       DOXYFILE_GEN="$(@D)/Doxyfile.generated"
       OUT_DIR="$(@D)/doxygen_output"
       OUT_ZIP="$$(pwd)/$@"