Add --no-color option

[andxyz]

Make the --color=false option, work properly.

The --no-color feature appears to be not be working properly, I have more work to do here. But this is a simplified fix.

Interestingly enough, this feature is in the documentation. (My guess, is maybe at one time, we had this --no-color feature?)

$ foreman --help start
Usage:
  foreman start [PROCESS]

Options:
  -c, [--color], [--no-color]          # Force color to be enabled
  -e, [--env=ENV]                      # Specify an environment file to load, defaults to .env
  -m, [--formation="alpha=5,bar=3"]    # Specify what processes will run and how many. Default: "all=1"
  -p, [--port=N]
  -t, [--timeout=N]                    # Specify the amount of time (in seconds) processes have to shutdown gracefully before receiving a SIGKILL, defaults to 5.
      [--timestamp], [--no-timestamp]  # Include timestamp in output
                                       # Default: true
  -f, [--procfile=PROCFILE]            # Default: Procfile
  -d, [--root=ROOT]                    # Default: Procfile directory

Start the application (or a specific PROCESS)

[andxyz]

Here is a pic of my terminal. it is hard to talk colors without some visuals

[ddollar]

Thor already supports the --no variants to boolean options. You could just check it for false (will be nil if unspecified)

Please also add a test that covers your change.

[andxyz]

Ah, I see, I wondered how that --no-color option was getting into the docs. It was a Thor thing.

Thanks for the pointers, I will work towards your suggested approach. And add tests of course.

[daande]

Thor already supports the --no variants to boolean options. You could just check it for false (will be nil if unspecified)

@ddollar I am confused by the ask here?

and yes we will add a test!

[andxyz]

I've updated things. However, adding tests in rspec that involve the def color? method, which relies on isatty, was getting nutty.
So I did manual testing and left it at that.