replace phonon dispersion downlaod with direct html links#579
Open
joehart2001 wants to merge 1 commit into
Open
replace phonon dispersion downlaod with direct html links#579joehart2001 wants to merge 1 commit into
joehart2001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
Phonon dispersion plot downloads failed with HTTP 413 (request too large) for models with complex structures. The download button worked by sending the full pre-rendered PNG, SVG, and JSON back to the server on every click -> for large structures this exceeded the server's request size limit. Fixed by replacing the server callback with direct browser download links, and updated the generic image download callback to run in the browser rather than making a server round-trip.
Linked issue
Resolves #
Testing