Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
tucked
approved these changes
Oct 17, 2022
| """ | ||
|
|
||
| __version__ = "0.5.0" | ||
| __version__ = "1.0.0" |
There was a problem hiding this comment.
Down with ZeroVer! 💯
(Nothing to do here, just pleased with this 😋)
| (timeout is not None or max_tries is not None) and poll_forever | ||
| ), "You cannot specify both the option to poll_forever and max_tries/timeout." | ||
| if not ((timeout is not None or max_tries is not None) or poll_forever): | ||
| raise AssertionError( |
There was a problem hiding this comment.
Since we're including this in a major release, I don't think it would be unreasonable to break compatibility by switching to a ValueError.
(FWIW, I don't actually need/rely on this at all. It's just more correct IMO.)
Alternatively, a compromise solution could be to create a custom exception for a while that inherits from both:
class ValueAssertionError(ValueError, AssertionError):
"""Backwards-compatible ValueError (catching AssertionError is deprecated!)"""
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for this issue #48
Also use bandit in pre-commit.