Skip to content
This repository was archived by the owner on Mar 25, 2021. It is now read-only.

Change Log, Plugin and Cache namespace for Guzzle 3.x#14

Open
carlos-granados wants to merge 4 commits intoddeboer:masterfrom
carlos-granados:patch-1
Open

Change Log, Plugin and Cache namespace for Guzzle 3.x#14
carlos-granados wants to merge 4 commits intoddeboer:masterfrom
carlos-granados:patch-1

Conversation

@carlos-granados
Copy link
Copy Markdown

In Guzzle 3.x the Log classes have been moved from Guzzle\Common\Log to Guzzle\Log, the Cache classes have been moved from Guzzle\Common\Cache to Guzzle\Cache and the Plugin classes have been moved from Guzzle\Http\Plugin to Guzzle\Plugin

Additionally, the CollectionPlugin has been removed and plugins have to be added individually

Edited two files to reflect this change

@mtdowling
Copy link
Copy Markdown
Contributor

Thanks!

I've gone ahead and tagged 1.0.0 of this bundle so that people can still use Guzzle 2. I've also created a guzzle2 branch so that the Guzzle 2.x series of the bundle can be maintained.

I'll let @gimler or someone more familiar with this bundle take a look at this PR.

@adrienbrault
Copy link
Copy Markdown
Contributor

ping @gimler

@gimler
Copy link
Copy Markdown
Collaborator

gimler commented Nov 13, 2012

sorry i will try to check that PR this week

@mattvick
Copy link
Copy Markdown

Hi @barelon,

I'm using Guzzle 3 is it ok to pull your patch?

BTW the GuzzleBundle documentation states that I should create a webservices.xml file, which I've done. However Guzzle 3 only appears to support "JSON or PHP files that return an array when included", taken from the code Guzzle/Service/AbstractConfigLoader.php.

The bundle appears not to work for Guzzle 3 throwing an InvalidArgumentException 'Unknown file extension'. zerkalica's "Symfony native configuration support" looks good but it is in the Guzzle2 branch..

Do you have a workaround for these issues?

Matthew

@matmar10
Copy link
Copy Markdown

@barelon - Thanks for the patch!

@mattvick
Copy link
Copy Markdown

For those interested this is good: https://github.com/misd-service-development/guzzle-bundle

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants