feat(Appraisal): added get comparables path to appraisals class#15
Open
alonssrodd3 wants to merge 1 commit intomainfrom
Open
feat(Appraisal): added get comparables path to appraisals class#15alonssrodd3 wants to merge 1 commit intomainfrom
alonssrodd3 wants to merge 1 commit intomainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
alonssrodd3
force-pushed
the
feature/metrics
branch
from
d109107 to
bee02be
Compare
wootsbot
reviewed
Jul 1, 2024
| developmentAmenities?: DevelopmentAmenities | ||
| isNewPropertyProb?: number | ||
| isHouse?: number | ||
| isSale?: number |
There was a problem hiding this comment.
I think we can align it as it is currently used in the other products and leave it as operationType
| m2PrivateTerrace?: number | ||
| hasView?: number | ||
| developmentAmenities?: DevelopmentAmenities | ||
| isNewPropertyProb?: number |
There was a problem hiding this comment.
the name of the property is more like a Boolean type value
-isNewPropertyProb?: number
+ isNewPropertyProb?: boolean
alonssrodd3
force-pushed
the
main
branch
2 times, most recently
from
8b60e09 to
360490d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.