Skip to content

Validate user existence before adding as co-author #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dd32 merged 1 commit into from
Mar 2, 2026
Merged

Validate user existence before adding as co-author #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions includes/class-map-co-authors.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ public static function add_co_author( int $post_id, int $user_id ): bool {
return false;
}

if ( ! get_userdata( $user_id ) ) {
return false;
}

// The post's original author never needs to be stored as a co-author.
if ( (int) $post->post_author === $user_id ) {
return true;
Expand Down
5 changes: 5 additions & 0 deletions tests/Test_Co_Authors.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ public function test_get_co_authors_returns_empty_array_by_default(): void {
$this->assertSame( array(), Co_Authors::get_co_authors( $this->post_id ) );
}

public function test_add_co_author_rejects_nonexistent_user(): void {
$this->assertFalse( Co_Authors::add_co_author( $this->post_id, 999999 ) );
$this->assertNotContains( 999999, Co_Authors::get_co_authors( $this->post_id ) );
}

public function test_add_co_author_returns_true(): void {
$this->assertTrue( Co_Authors::add_co_author( $this->post_id, $this->user_id ) );
}
Expand Down