You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SD-2769: Correct Endorsement Chain description
Removing lines from the Endorsee description and "SME note"
PR Type
Documentation
Description
Remove misleading text from Endorse action description
Delete SME note about endorsementChain naming agreement
Clarify endorsement behavior across multiple API specs
Diagram Walkthrough
flowchart LR
A["endorsementChain descriptions"] -- "Remove misleading constraint" --> B["Endorse action clarified"]
A -- "Delete SME note" --> C["Cleaner documentation"]
B --> D["Updated specs"]
C --> D
Loading
File Walkthrough
Relevant files
Documentation
EBL_END_v3.0.3.yaml
Remove constraint and note from Endorse action
ebl/v3/endorsement/EBL_END_v3.0.3.yaml
Removed phrase stating newly appointed endorsee may NOT further endorse
Deleted SME note about endorsementChain naming agreement
-- **Endorse:** The act of transferring the rights and obligations associated with the eBL to a new endorsee, meaning the designated recipient of the action, allowing them to claim or deal with the goods. Only applicable to negotiable eBL (`isToOrder=true`).+- **Endorse:** The act of transferring the rights and obligations associated with the eBL to a new endorsee, meaning the designated recipient of the action, allowing them to claim or deal with the goods. The newly appointed endorsee may **NOT** further endorse the eBL to another party. Only applicable to negotiable eBL (`isToOrder=true`).
Apply / Chat
Suggestion importance[1-10]: 7
__
Why: The suggestion correctly identifies that the PR introduces ambiguity by removing the distinction between the Endorse and Endorse to Order actions, which is a valid concern for API clarity.
Medium
General
Explicitly forbid re-endorsement
Add a note to the Endorse action description to clarify that it does not allow further endorsement, distinguishing it from Endorse to Order.
-- **Endorse:** The act of transferring the rights and obligations associated with the eBL to a new endorsee, meaning the designated recipient of the action, allowing them to claim or deal with the goods. Only applicable to negotiable eBL (`isToOrder=true`).+- **Endorse:** The act of transferring the rights and obligations associated with the eBL to a new endorsee, meaning the designated recipient of the action, allowing them to claim or deal with the goods. Only applicable to negotiable eBL (`isToOrder=true`). This endorsement does not allow further endorsement to another party.
Apply / Chat
Suggestion importance[1-10]: 7
__
Why: The suggestion correctly identifies that the PR introduces ambiguity by removing the distinction between the Endorse and Endorse to Order actions, which is a valid concern for API clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
SD-2769: Correct Endorsement Chain description
Removing lines from the Endorsee description and "SME note"
PR Type
Documentation
Description
Remove misleading text from Endorse action description
Delete SME note about endorsementChain naming agreement
Clarify endorsement behavior across multiple API specs
Diagram Walkthrough
File Walkthrough
EBL_END_v3.0.3.yaml
Remove constraint and note from Endorse actionebl/v3/endorsement/EBL_END_v3.0.3.yaml
endorse
EBL_SUR_v3.0.3.yaml
Remove constraint and note from Endorse actionebl/v3/surrender/EBL_SUR_v3.0.3.yaml
endorse