Skip to content

Add native mac explorer trash shortcut#213

Draft
parsakhaz wants to merge 1 commit into
mainfrom
explorer-imporvements
Draft

Add native mac explorer trash shortcut#213
parsakhaz wants to merge 1 commit into
mainfrom
explorer-imporvements

Conversation

@parsakhaz
Copy link
Copy Markdown
Member

Summary

  • Add macOS Cmd+Delete / Cmd+Backspace support in the explorer to move selected items to Trash without a confirmation popup.
  • Preserve confirmation prompts for plain Delete / Backspace, the inline trash button, and context-menu delete.
  • Guard the no-confirm IPC path so Trash failures return an error instead of falling through to permanent deletion.

Validation

  • pnpm typecheck passed
  • pnpm lint passed with existing warnings
  • Pre-commit hook reran typecheck and lint successfully

Notes

Manual macOS UI verification is still expected: select multiple explorer files, use Cmd+Delete / Cmd+Backspace, and confirm they move to Trash without a popup.

Copy link
Copy Markdown
Member Author

@codex review

Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant