Skip to content

feat(llm, openai): Add GPT-5.4 family and none reasoning effort #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeanMertz merged 2 commits into from
Mar 19, 2026
Merged

feat(llm, openai): Add GPT-5.4 family and none reasoning effort #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86423ad
feat(llm, openai): Add GPT-5.4 family and `none` reasoning effort
JeanMertz Mar 19, 2026
d1781fb
fixup! feat(llm, openai): Add GPT-5.4 family and `none` reasoning effort
JeanMertz Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .config/supply-chain/audits.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,17 @@ who = "Jean Mertz <git@jeanmertz.com>"
criteria = "safe-to-deploy"
delta = "0.3.3 -> 0.3.4"

[[audits.openai_responses]]
who = "Jean Mertz <git@jeanmertz.com>"
criteria = "safe-to-deploy"
version = "0.1.6"

[[audits.openai_responses]]
who = "Jean Mertz <git@jeanmertz.com>"
criteria = "safe-to-deploy"
delta = "0.1.6 -> 0.1.6@git:1f5761a9c7361f5bc56725d15c1309c72f52af5e"
importable = false

[[audits.pastey]]
who = "Jean Mertz <git@jeanmertz.com>"
criteria = "safe-to-deploy"
Expand Down
8 changes: 0 additions & 8 deletions .config/supply-chain/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,18 +445,10 @@ criteria = "safe-to-deploy"
version = "1.1.0"
criteria = "safe-to-deploy"

[[exemptions.openai_responses]]
version = "0.1.6@git:87a31cd3ebac62f83efef2586c34a50141d33ffe"
criteria = "safe-to-deploy"

[[exemptions.os_pipe]]
version = "1.2.2"
criteria = "safe-to-deploy"

[[exemptions.parking]]
version = "2.2.1"
criteria = "safe-to-deploy"

[[exemptions.path-tree]]
version = "0.8.3"
criteria = "safe-to-deploy"
Expand Down
34 changes: 6 additions & 28 deletions .config/supply-chain/imports.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,13 +812,6 @@ user-id = 64539
user-login = "kennykerr"
user-name = "Kenny Kerr"

[[publisher.windows-core]]
version = "0.56.0"
when = "2024-04-12"
user-id = 64539
user-login = "kennykerr"
user-name = "Kenny Kerr"

[[publisher.windows-core]]
version = "0.61.2"
when = "2025-05-19"
Expand All @@ -833,27 +826,13 @@ user-id = 64539
user-login = "kennykerr"
user-name = "Kenny Kerr"

[[publisher.windows-implement]]
version = "0.56.0"
when = "2024-04-12"
user-id = 64539
user-login = "kennykerr"
user-name = "Kenny Kerr"

[[publisher.windows-implement]]
version = "0.60.2"
when = "2025-10-06"
user-id = 64539
user-login = "kennykerr"
user-name = "Kenny Kerr"

[[publisher.windows-interface]]
version = "0.56.0"
when = "2024-04-12"
user-id = 64539
user-login = "kennykerr"
user-name = "Kenny Kerr"

[[publisher.windows-interface]]
version = "0.59.3"
when = "2025-10-06"
Expand All @@ -868,13 +847,6 @@ user-id = 64539
user-login = "kennykerr"
user-name = "Kenny Kerr"

[[publisher.windows-result]]
version = "0.1.2"
when = "2024-06-07"
user-id = 64539
user-login = "kennykerr"
user-name = "Kenny Kerr"

[[publisher.windows-result]]
version = "0.3.4"
when = "2025-05-19"
Expand Down Expand Up @@ -1363,6 +1335,12 @@ criteria = "safe-to-deploy"
delta = "0.46.0 -> 0.50.1"
notes = "Lots of stylistic/rust-related chanegs, plus new features, but nothing out of the ordrinary."

[[audits.bytecode-alliance.audits.parking]]
who = "Chris Fallin <chris@cfallin.org>"
criteria = "safe-to-deploy"
version = "2.2.1"
notes = "forbid-unsafe crate with straightforward imports."

[[audits.bytecode-alliance.audits.percent-encoding]]
who = "Alex Crichton <alex@alexcrichton.com>"
criteria = "safe-to-deploy"
Expand Down
61 changes: 9 additions & 52 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 17 additions & 2 deletions crates/jp_llm/src/model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ impl ModelDetails {

// Leveled
Some(ReasoningDetails::Leveled {
none: _,
xlow: _,
low,
medium,
Expand Down Expand Up @@ -225,6 +226,9 @@ pub enum ReasoningDetails {
/// reasoning configuration, but instead offer specific "efforts" of
/// reasoning, such as low/medium/high effort.
Leveled {
/// Whether the model supports completely disabling reasoning.
none: bool,

/// Whether the model supports extremely low effort reasoning.
xlow: bool,

Expand Down Expand Up @@ -265,8 +269,16 @@ impl ReasoningDetails {

#[must_use]
#[expect(clippy::fn_params_excessive_bools)]
pub fn leveled(xlow: bool, low: bool, medium: bool, high: bool, xhigh: bool) -> Self {
pub fn leveled(
none: bool,
xlow: bool,
low: bool,
medium: bool,
high: bool,
xhigh: bool,
) -> Self {
Self::Leveled {
none,
xlow,
low,
medium,
Expand Down Expand Up @@ -312,13 +324,16 @@ impl ReasoningDetails {
pub fn lowest_effort(&self) -> Option<ReasoningEffort> {
match self {
Self::Leveled {
none,
xlow,
low,
medium,
high,
xhigh,
} => {
if *xlow {
if *none {
Some(ReasoningEffort::None)
} else if *xlow {
Some(ReasoningEffort::Xlow)
} else if *low {
Some(ReasoningEffort::Low)
Expand Down
13 changes: 10 additions & 3 deletions crates/jp_llm/src/provider/google.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ fn create_request(
},
thinking_level: match details {
ReasoningDetails::Leveled {
none: _,
xlow,
low,
medium,
Expand Down Expand Up @@ -370,7 +371,9 @@ fn map_model(model: types::Model) -> ModelDetails {
display_name,
context_window,
max_output_tokens,
reasoning: Some(ReasoningDetails::leveled(false, true, true, true, false)),
reasoning: Some(ReasoningDetails::leveled(
false, false, true, true, true, false,
)),
knowledge_cutoff: Some(NaiveDate::from_ymd_opt(2025, 1, 1).unwrap()),
deprecated: Some(ModelDeprecation::Active),
structured_output: None,
Expand All @@ -382,7 +385,9 @@ fn map_model(model: types::Model) -> ModelDetails {
display_name,
context_window,
max_output_tokens,
reasoning: Some(ReasoningDetails::leveled(false, true, false, true, false)),
reasoning: Some(ReasoningDetails::leveled(
false, false, true, false, true, false,
)),
knowledge_cutoff: Some(NaiveDate::from_ymd_opt(2025, 1, 1).unwrap()),
deprecated: Some(ModelDeprecation::Active),
structured_output: None,
Expand All @@ -393,7 +398,9 @@ fn map_model(model: types::Model) -> ModelDetails {
display_name,
context_window,
max_output_tokens,
reasoning: Some(ReasoningDetails::leveled(true, true, true, true, false)),
reasoning: Some(ReasoningDetails::leveled(
false, true, true, true, true, false,
)),
knowledge_cutoff: Some(NaiveDate::from_ymd_opt(2025, 1, 1).unwrap()),
deprecated: Some(ModelDeprecation::Active),
structured_output: None,
Expand Down
Loading
Loading