Conversation
The `commit` and `rfd-this` just recipes were missing the `elif [ -n "$args" ]` branch, leaving them unable to handle the case where positional arguments are provided without a leading `-`. Both recipes now match the `stage` recipe's behavior. Additionally, the `stage` recipe was joining the default message and user-provided context with a single space. This has been updated to use `\n\n` for proper paragraph separation, and the same separator is now used consistently across all three recipes. Also adds `/.jp/conversations/.trash` to `.gitignore` and removes a stale conversation directory exception. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
commitandrfd-thisjust recipes were missing theelif [ -n "$args" ]branch, leaving them unable to handle the case where positional arguments are provided without a leading-. Both recipes now match thestagerecipe's behavior.Additionally, the
stagerecipe was joining the default message and user-provided context with a single space. This has been updated to use\n\nfor proper paragraph separation, and the same separator is now used consistently across all three recipes.Also adds
/.jp/conversations/.trashto.gitignoreand removes a stale conversation directory exception.