Skip to content

harden: deduplicate ALL_TIERS by dataSize to eliminate redundant RPCs#199

Open
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:harden/dedup-all-tiers-by-datasize
Open

harden: deduplicate ALL_TIERS by dataSize to eliminate redundant RPCs#199
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:harden/dedup-all-tiers-by-datasize

Conversation

@0x-SquidSol
Copy link
Copy Markdown
Contributor

Summary

  • V1D and V2 share identical slab sizes (small=65088, large=1025568)
  • Both fired separate getProgramAccounts queries with the same dataSize filter, returning identical results
  • detectSlabLayout disambiguates layouts from the actual account data's version field, not from the tier hint
  • Fix: Map-based dedup by dataSize, keeping the entry with higher maxAccounts. Eliminates 2 redundant RPC calls per discoverMarkets invocation (~400ms saved in sequential mode)

Test plan

  • Discovery tests pass (60/60) — tier count assertion uses <= so dedup doesn't break it
  • No new test failures (729 passed, same 16 pre-existing)

🤖 Generated with Claude Code

V1D and V2 share identical slab sizes (e.g., small=65088,
large=1025568). Both fired separate getProgramAccounts queries
with the same dataSize filter, returning identical results —
pure waste. detectSlabLayout disambiguates layouts from account
data, not from the tier hint.

Deduplicates ALL_TIERS by dataSize using a Map, keeping the
entry with the higher maxAccounts hint. Eliminates 2 redundant
RPC calls per discoverMarkets invocation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 13, 2026

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 40 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 26 minutes and 40 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bd840a5b-abe8-42ce-ba2d-1f221486a37f

📥 Commits

Reviewing files that changed from the base of the PR and between 2f80d79 and d0a746b.

📒 Files selected for processing (1)
  • src/solana/discovery.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant