harden: validate all AdlApiResult top-level fields before cast

[0x-SquidSol]

Summary

• fetchAdlRankings validated rankings array and idx fields but used as AdlApiResult cast without checking top-level fields
• A compromised or updated API returning adlNeeded: "yes" (string instead of boolean) or pnlPosTot: 12345 (number instead of string) would silently pass through
• Downstream code like BigInt(result.pnlPosTot) would throw a confusing TypeError far from the actual problem
• Fix: Added typeof checks for the 5 most critical fields: adlNeeded (boolean), capExceeded (boolean), slabAddress (string), pnlPosTot (string), maxPnlCap (string)
• Throws immediately with a descriptive error identifying which field has the wrong type

Test plan

• ADL tests pass (26/26)
• No new test failures (729 passed, same 16 pre-existing)
• Verify malformed API response with wrong types throws descriptive error

🤖 Generated with Claude Code

[coderabbitai]

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 33 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 33 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ccd5b9cb-fe94-4674-b984-6614287ece6a

📥 Commits

Reviewing files that changed from the base of the PR and between 2f80d79 and 50fd335.

📒 Files selected for processing (1)

• src/solana/adl.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}