harden: validate slab magic in parseEngine and parseConfig#191
harden: validate slab magic in parseEngine and parseConfig#1910x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
Conversation
parseEngine and parseConfig can be called directly without going through parseHeader (which validates magic). adl.ts calls both directly. Without magic validation, a malicious RPC returning arbitrary bytes of a known slab size would be silently parsed as valid engine/config data — producing garbage vault balances, PnL, and oracle addresses. Added PERCOLAT magic check at the top of both functions. Cheap (one u64 read) and catches poisoned data before any field parsing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 6 minutes and 25 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
parseEngineandparseConfigcan be called directly without going throughparseHeader(which validates the PERCOLAT magic bytes)adl.tscalls both functions directly —isAdlTriggered,rankAdlPositionsreadU64LE(data, 0) !== MAGIC) at the top of both functionsTest plan
🤖 Generated with Claude Code