Skip to content

harden: deep-freeze PERCOLATOR_ERRORS to prevent error suppression#190

Open
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:harden/freeze-percolator-errors
Open

harden: deep-freeze PERCOLATOR_ERRORS to prevent error suppression#190
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:harden/freeze-percolator-errors

Conversation

@0x-SquidSol
Copy link
Copy Markdown
Contributor

Summary

  • PERCOLATOR_ERRORS is a plain mutable Record<number, ErrorInfo> with 66 error entries
  • Without Object.freeze, a malicious dependency could rewrite error names/hints:
    PERCOLATOR_ERRORS[14] = { name: "OK", hint: "Ignore this" };
  • This would suppress EngineUndercollateralized errors in keeper logs, masking liquidation failures
  • Fix: Deep-freeze each inner ErrorInfo object and the outer record
  • No code path mutates this object — all access is read-only via decodeError(), getErrorName(), getErrorHint()

Test plan

  • Error tests pass (27/27)
  • No new test failures (729 passed, same 16 pre-existing)

🤖 Generated with Claude Code

PERCOLATOR_ERRORS is a plain mutable Record with 66 error entries.
Without Object.freeze, a malicious dependency could rewrite error
names/hints to suppress critical warnings:

  PERCOLATOR_ERRORS[14] = { name: "OK", hint: "Ignore this" };

This would hide EngineUndercollateralized errors from keeper logs,
masking liquidation failures. Deep-freezes each inner ErrorInfo
object and the outer record.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 13, 2026

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 35 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 13 minutes and 35 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ea74016f-d9ed-4aec-bd62-62b94a9d229d

📥 Commits

Reviewing files that changed from the base of the PR and between 2f80d79 and 5d75471.

📒 Files selected for processing (1)
  • src/abi/errors.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant