Skip to content

fix(slab): correct HOST bitmapOff double-subtraction in buildLayoutV12_1#187

Open
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/v12-host-bitmap-double-subtract
Open

fix(slab): correct HOST bitmapOff double-subtraction in buildLayoutV12_1#187
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/v12-host-bitmap-double-subtract

Conversation

@0x-SquidSol
Copy link
Copy Markdown
Contributor

Summary

  • buildLayoutV12_1 computed HOST bitmapOff as V12_1_ENGINE_BITMAP_OFF - V12_1_ENGINE_OFF (1016 - 648 = 368)
  • But V12_1_ENGINE_BITMAP_OFF (1016) is already relative to engineOff, consistent with computeSlabSize and all other layout builders
  • The subtraction double-adjusted, producing 368 instead of 1016
  • This caused wrong accountsOff for HOST test slabs and 8 failing drift-check tests
  • One-character fix: remove the - V12_1_ENGINE_OFF subtraction

Test plan

  • drift-check tests: 46 passed (was 38 passed + 8 failed — all 8 HOST bitmapOff failures resolved)
  • Full suite: 737 passed (8 remaining failures are pre-existing ADL mock issues)

🤖 Generated with Claude Code

buildLayoutV12_1 computed HOST bitmapOff as
V12_1_ENGINE_BITMAP_OFF - V12_1_ENGINE_OFF (1016 - 648 = 368).
But V12_1_ENGINE_BITMAP_OFF (1016) is already relative to
engineOff (consistent with computeSlabSize and all other layout
builders). The subtraction double-adjusted, producing 368 instead
of 1016. This caused wrong accountsOff for HOST test slabs and
8 failing drift-check tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 13, 2026

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 47 minutes and 29 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 47 minutes and 29 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d11ca9cb-022f-4cbb-aebb-165aabf67709

📥 Commits

Reviewing files that changed from the base of the PR and between 2f80d79 and 29222b8.

📒 Files selected for processing (1)
  • src/solana/slab.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant