fix(slab): correct HOST bitmapOff double-subtraction in buildLayoutV12_1#187
fix(slab): correct HOST bitmapOff double-subtraction in buildLayoutV12_1#1870x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
Conversation
buildLayoutV12_1 computed HOST bitmapOff as V12_1_ENGINE_BITMAP_OFF - V12_1_ENGINE_OFF (1016 - 648 = 368). But V12_1_ENGINE_BITMAP_OFF (1016) is already relative to engineOff (consistent with computeSlabSize and all other layout builders). The subtraction double-adjusted, producing 368 instead of 1016. This caused wrong accountsOff for HOST test slabs and 8 failing drift-check tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 47 minutes and 29 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
buildLayoutV12_1computed HOSTbitmapOffasV12_1_ENGINE_BITMAP_OFF - V12_1_ENGINE_OFF(1016 - 648 = 368)V12_1_ENGINE_BITMAP_OFF(1016) is already relative toengineOff, consistent withcomputeSlabSizeand all other layout buildersaccountsOfffor HOST test slabs and 8 failing drift-check tests- V12_1_ENGINE_OFFsubtractionTest plan
🤖 Generated with Claude Code