fix(slab): export V12.1 SBF tier sizes for mainnet discovery#184
fix(slab): export V12.1 SBF tier sizes for mainnet discovery#1840x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
Conversation
SLAB_TIERS_V12_1 computes sizes using HOST/aarch64 constants (engineOff=648, accountSize=320) but mainnet deploys the SBF binary (engineOff=616, accountSize=280). The size difference is ~14% per tier (e.g., medium: 331,544 HOST vs 290,120 SBF). Discovery's getProgramAccounts dataSize filters used HOST sizes and would find zero V12.1 slabs on mainnet since no on-chain account matches the HOST-computed size. Added SLAB_TIERS_V12_1_SBF export with SBF-computed sizes. Changed SLAB_TIERS (the mainnet default) to alias SBF sizes. Added both HOST and SBF V12.1 sizes to ALL_TIERS for discovery of slabs from any build target. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR introduces SBF-specific slab tier constants with different layout offsets and updates the discovery module to use these new SBF values as the default while maintaining support for HOST/test builds in tier coverage. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
SLAB_TIERS_V12_1computes sizes using HOST/aarch64 constants (engineOff=648,accountSize=320) but mainnet deploys the SBF binary (engineOff=616,accountSize=280)SLAB_TIERS(the mainnet default) aliased to HOST sizes —discoverMarketsgetProgramAccountsdataSizefilters would find zero V12.1 slabs on mainnetSLAB_TIERS_V12_1_SBFexport computed from SBF constants. ChangedSLAB_TIERSto alias SBF sizes. Added both HOST and SBF V12.1 toALL_TIERSfor discovery of slabs from any build target.SLAB_TIERS_V12_1(HOST) preserved unchanged for test builds and backward compatibilityTest plan
discoverMarketsfinds V12.1 SBF slabs via dataSize filter🤖 Generated with Claude Code
Summary by CodeRabbit