fix(chart): bump dark-theme grid + border contrast one tone#2148
fix(chart): bump dark-theme grid + border contrast one tone#21480x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
Conversation
The chart panel's grid and border alphas were at the floor of what
professional trading UIs use (4% / 6% white on the dark bg), which
made the chart blend into the surrounding page bg without giving
it a defined panel edge. Bumping each up one tone:
gridColor: 0.04 → 0.07
borderColor: 0.06 → 0.10
For reference, peer products run grids around 0.06–0.10 and borders
0.08–0.12 on dark themes. The new values land in the bottom of that
range so they read as subtle structure rather than as graph paper.
Indicator reference lines stay correctly layered above the new grid:
RSI 30 / 70 dashed lines: derived from theme.textColor at 0.25
alpha, multiplied through textColor's 0.45 = ~0.11 effective
MACD signal line: theme.textColor at 0.75
= ~0.34 effective
Bollinger bands: per-indicator palette color (independent)
All sit clearly above the 0.07 grid, so the hierarchy candles >
indicator lines > grid is preserved.
Light theme untouched — at gridColor 0.05 / borderColor 0.10 on
the light #FAFAFD bg the contrast is already in industry-standard
range; the same percentage-point bump on a light bg would push
into "graph paper" territory.
Tests: 365 trade + hook tests passing.
|
@0x-SquidSol is attempting to deploy a commit to the Khubair Nasir's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The chart panel's grid and border alphas sat at the floor of what professional trading UIs use (4% / 6% white on the dark bg), which made the chart blend into the surrounding page bg without giving it a defined panel edge. Bumping each up one tone:
For reference, peer products run grids around 0.06–0.10 and borders 0.08–0.12 on dark themes. The new values land in the bottom of that range so they read as subtle structure rather than as graph paper.
Indicator hierarchy preserved
Hierarchy candles > indicator lines > grid is intact.
What stays untouched
Test plan
🤖 Generated with Claude Code