Skip to content

Bump market info bar labels to primary text#2143

Merged
dcccrypto merged 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/market-info-bar-contrast
May 7, 2026
Merged

Bump market info bar labels to primary text#2143
dcccrypto merged 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/market-info-bar-contrast

Conversation

@0x-SquidSol
Copy link
Copy Markdown
Contributor

Summary

The market info bar's five stat labels (Vol 24h, Open Interest, 24h High, 24h Low, Funding / 8h) and the `PERP` tag next to the symbol were rendering at `--text-dim` — a token meant for placeholder-style metadata. At 9 px uppercase, sitting on the dark bg, the text was nearly illegible without bumping display brightness. Promoting them to `--text` matches the `{SYMBOL}/USD` symbol header and the bar's other primary content.

The visual hierarchy is preserved by font-size + uppercase tracking (labels stay 9 px / tracking-[0.1em], values stay 12 px / mono) instead of by brightness.

What changes

Element Before After
`PERP` tag `--text-dim` `--text`
"Vol 24h" label `--text-dim` `--text`
"Open Interest" label `--text-dim` `--text`
"24h High" label `--text-dim` `--text`
"24h Low" label `--text-dim` `--text`
"Funding / 8h" label `--text-dim` `--text`

Stat values are untouched — volumes / OI stay `--text`, 24h high stays `--long`, 24h low stays `--short`, funding stays its directional colour.

Test plan

  • `vitest run` for `gh1654-market-info-bar-visibility` and `trading-ui-phase2` — 17/17 passing
  • Manual smoke: open the trade page, verify the labels read clearly without bumping monitor brightness
  • Manual smoke: light theme — confirm `--text` still has adequate contrast on the lighter info-bar surface

🤖 Generated with Claude Code

The five stat labels (Vol 24h, Open Interest, 24h High, 24h Low,
Funding / 8h) and the PERP tag next to the symbol were rendering
at --text-dim, which on the dark info-bar bg sits below
comfortable readability for short uppercase labels at 9 px.
Promoting them to --text matches the symbol "{SYMBOL}/USD" header
and the rest of the bar's primary content. The 9 px size + uppercase
tracking still differentiate them from the value rows below — the
hierarchy is now driven by font-size and casing rather than by
brightness.

Stat values themselves (volumes, prices, funding rate) are
untouched — they remain --text / --long / --short / fundingColor
as appropriate.
@0x-SquidSol 0x-SquidSol requested a review from dcccrypto as a code owner May 6, 2026 14:39
@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026

@0x-SquidSol is attempting to deploy a commit to the Khubair Nasir's projects Team on Vercel.

A member of the Team first needs to authorize it.

@0x-SquidSol
Copy link
Copy Markdown
Contributor Author

Closing for local review — will reopen once approved.

@0x-SquidSol 0x-SquidSol closed this May 6, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 53 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 51f645d5-f699-448a-9b59-7ab5331f35ed

📥 Commits

Reviewing files that changed from the base of the PR and between 59c3f78 and a7c2aae.

📒 Files selected for processing (1)
  • app/components/trade/MarketInfoBar.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@0x-SquidSol 0x-SquidSol reopened this May 6, 2026
@dcccrypto dcccrypto merged commit 89ab081 into dcccrypto:main May 7, 2026
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants