Skip to content

fix: validate Supabase fields independently (M3)#93

Open
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/m3-supabase-field-validation
Open

fix: validate Supabase fields independently (M3)#93
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/m3-supabase-field-validation

Conversation

@0x-SquidSol
Copy link
Copy Markdown
Contributor

Summary

  • Supabase row validation used continue which discarded the entire row when one field failed base58 check
  • A HYPERP market with a valid dex_pool_address but corrupted mainnet_ca lost its pool address
  • Now validates each field independently — invalid field is set to undefined, valid sibling is preserved

Test plan

  • All 133 tests pass

🤖 Generated with Claude Code

When a Supabase row had one invalid field (dex_pool_address or
mainnet_ca failing base58 validation), the `continue` discarded the
entire row — including the other valid field. A HYPERP market with a
corrupted mainnet_ca but valid dex_pool_address lost its pool address.

Validate each field independently: null out only the invalid field
and always store the row in dbMarkets with whichever fields are valid.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 5 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 5 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f3b84d0d-6136-48aa-ae83-75b0e761bc65

📥 Commits

Reviewing files that changed from the base of the PR and between 3280971 and 1889611.

📒 Files selected for processing (1)
  • src/services/crank.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant