Skip to content

fix: reject ALLOW_INSECURE_RPC on mainnet (H9)#91

Open
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/h9-insecure-rpc-mainnet-guard
Open

fix: reject ALLOW_INSECURE_RPC on mainnet (H9)#91
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/h9-insecure-rpc-mainnet-guard

Conversation

@0x-SquidSol
Copy link
Copy Markdown
Contributor

Summary

  • ALLOW_INSECURE_RPC=true bypassed all RPC URL scheme validation, including on mainnet
  • A misconfigured deploy could send signed transactions with real funds over plaintext HTTP
  • Now throws at startup when ALLOW_INSECURE_RPC=true and NETWORK=mainnet

Test plan

  • throws when ALLOW_INSECURE_RPC=true and NETWORK=mainnet
  • does not throw when ALLOW_INSECURE_RPC=true on devnet
  • All 135 tests pass

🤖 Generated with Claude Code

ALLOW_INSECURE_RPC=true bypassed all RPC URL scheme validation
including on mainnet. A misconfigured deploy could run mainnet with
plaintext HTTP, exposing signed transactions with real funds to MITM.

Now throws at startup if ALLOW_INSECURE_RPC=true when NETWORK=mainnet.
Devnet usage is unaffected.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 11 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 15 minutes and 11 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 50a9b223-2d3d-4945-b8b1-f68e47ca2068

📥 Commits

Reviewing files that changed from the base of the PR and between 3280971 and 6957650.

📒 Files selected for processing (2)
  • src/env-guards.ts
  • tests/env-guards.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant