Skip to content

fix: graceful shutdown on uncaughtException (H8)#90

Open
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/h8-uncaught-exception-shutdown
Open

fix: graceful shutdown on uncaughtException (H8)#90
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/h8-uncaught-exception-shutdown

Conversation

@0x-SquidSol
Copy link
Copy Markdown
Contributor

Summary

  • The uncaughtException handler swallowed the exception and continued execution
  • Per Node.js docs, after an uncaught exception the process may be in undefined state
  • Continuing risks corrupted in-memory state while signing financial transactions
  • Now triggers graceful shutdown; Railway's ON_FAILURE restart policy brings the keeper back cleanly

Test plan

  • All 133 tests pass

🤖 Generated with Claude Code

Per Node.js docs, uncaughtException means the process is in an
undefined state. The previous handler swallowed the exception and
continued, risking corrupted in-memory state (half-written maps,
broken invariants) while signing financial transactions.

Now triggers graceful shutdown instead. Railway's ON_FAILURE restart
policy (max 10 retries) will bring the keeper back up cleanly with
fresh state.

The unhandledRejection handler is unchanged — continuing after
unhandled Promise rejections is safe per Node.js design.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 40 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 24 minutes and 40 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d93d7e8d-5701-468f-a35d-7e9c49bfd2a7

📥 Commits

Reviewing files that changed from the base of the PR and between 4fd5e86 and 204d3c2.

📒 Files selected for processing (1)
  • src/index.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant