Skip to content

fix: snapshot markets Map in ADL scanAll (H6)#88

Open
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/h6-adl-markets-snapshot
Open

fix: snapshot markets Map in ADL scanAll (H6)#88
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/h6-adl-markets-snapshot

Conversation

@0x-SquidSol
Copy link
Copy Markdown
Contributor

Summary

  • ADL scanAll() iterated the live CrankService.markets Map reference
  • CrankService.discover() can add/delete markets via async interleaving during the ADL scan loop
  • This caused undefined iterator behavior when the Map was mutated mid-iteration
  • LiquidationService already correctly snapshots with new Map(getMarkets()) at line 611

Fix

One-line change: new Map(this._getMarkets()) instead of this._getMarkets().

Test plan

  • All 133 tests pass

🤖 Generated with Claude Code

…on (H6)

ADL scanAll() iterated the live CrankService markets Map reference.
CrankService.discover() can add/delete markets via async interleaving
during the ADL scan loop, causing undefined iterator behavior.

Snapshot with new Map() before iterating, matching the pattern already
used by LiquidationService at liquidation.ts:611.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 3 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 4 minutes and 3 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 17b7c744-3eea-4f90-985c-7d11adb67228

📥 Commits

Reviewing files that changed from the base of the PR and between 4fd5e86 and 6e98a13.

📒 Files selected for processing (1)
  • src/services/adl.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant