fix: enforce on-chain fallback 60s cap for new markets (H2)#85
fix: enforce on-chain fallback 60s cap for new markets (H2)#850x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
Conversation
The M-4 on-chain fallback time cap was guarded by `lastExternal > 0`, which meant markets that never received an external price (new markets, unlisted tokens) had no time limit — the stale on-chain price was pushed indefinitely. Seed `lastExternalPriceMs` to `Date.now()` on first encounter so: - New markets get a 60s grace window from first fallback attempt - After 60s with no external price, the oracle goes stale naturally - The `lastExternal > 0` guard is no longer needed Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 2 minutes and 27 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
lastExternal > 0was bypassed for any market that never received an external price (DexScreener/Jupiter), becauselastExternalPriceMsdefaulted to0authorityPriceE6would be pushed forever for new/unlisted marketsFix
Seed
lastExternalPriceMstoDate.now()on first encounter of each market:lastExternal > 0guard sincelastExternalis now always a real timestampTest plan
🤖 Generated with Claude Code