Skip to content

fix: rate-limit stale oracle alert to once per 5 minutes (N8)#106

Open
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/n8-oracle-stale-alert-ratelimit
Open

fix: rate-limit stale oracle alert to once per 5 minutes (N8)#106
0x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/n8-oracle-stale-alert-ratelimit

Conversation

@0x-SquidSol
Copy link
Copy Markdown
Contributor

Summary

  • Stale oracle alert fired sendCriticalAlert every 60s with no cooldown
  • A 30-minute stale oracle produced ~25 duplicate Discord alerts
  • The liquidation stale alert already had a 5-minute cooldown (_lastLiqStaleAlertTime) — this was simply omitted for the oracle alert

Fix

Add _lastOracleStaleAlertTime with identical 5-minute cooldown pattern. Alert fires at most once per 5 minutes while any oracle is stale.

Test plan

  • All 133 tests pass

🤖 Generated with Claude Code

The stale oracle alert fired sendCriticalAlert every 60 seconds with
no cooldown as long as any market had a stale oracle. A 30-minute
stale oracle produced ~25 duplicate Discord alerts, causing alert
fatigue.

Add _lastOracleStaleAlertTime with a 5-minute cooldown, matching the
pattern already used by the liquidation stale alert
(_lastLiqStaleAlertTime at line 101).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 43 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 6 minutes and 43 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2c5e9cf2-db08-4e6f-bb4c-3c9dbd0fe536

📥 Commits

Reviewing files that changed from the base of the PR and between 3280971 and 9792f46.

📒 Files selected for processing (1)
  • src/index.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant