fix: remove watchdog force-reset to prevent concurrent cycle overlap (N3)

[0x-SquidSol]

Summary

All three service watchdogs detected hung cycles by resetting the _cycling/_scanning flag. But the old async operation continued running — it was never cancelled. The next interval tick started a new cycle, so two cycles ran concurrently:

• Duplicate transactions sent to the same markets (wasted SOL)
• State corruption from two async operations mutating shared Maps/counters
• The old cycle's finally block eventually cleared the flag mid-way through a newer cycle, potentially enabling a third concurrent cycle

Fix

Remove this._cycling = false / this._scanning = false from all three watchdog branches. The watchdog now logs + alerts but does NOT reset the flag. Cycles finish naturally via RPC timeouts (15s per call via withTimeout).

Affected services:

• CrankService — crank.ts
• LiquidationService — liquidation.ts
• AdlService — adl.ts

Test plan

• All 133 tests pass
• Updated ADL watchdog test to expect _cycling = true (flag preserved) while still verifying alert is sent

🤖 Generated with Claude Code

[coderabbitai]

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 53 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 6 minutes and 53 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5f81727f-bff8-4b8d-831f-f5d22dba9bcc

📥 Commits

Reviewing files that changed from the base of the PR and between 3280971 and 9af15e1.

📒 Files selected for processing (4)

• src/services/adl.ts
• src/services/crank.ts
• src/services/liquidation.ts
• tests/services/adl.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}