fix: don't count transient RPC errors toward market deactivation (N2)#100
fix: don't count transient RPC errors toward market deactivation (N2)#1000x-SquidSol wants to merge 1 commit intodcccrypto:mainfrom
Conversation
The crankMarket() catch block incremented consecutiveFailures for ALL errors including transient ones (429, timeout, socket reset, 502/503). After 10 consecutive transient errors — common during RPC provider hiccups — a perfectly healthy market was deactivated until the next discovery cycle (5 min default). Now classify errors before incrementing: transient RPC/network errors (429, rate limit, timeout, socket, ECONNREFUSED, 502, 503, block height exceeded) are logged at warn level but do NOT increment consecutiveFailures. Only deterministic program-level errors count toward deactivation. Matches the transient error classification pattern already used by liquidation.ts fetchSlabWithRetry(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 19 minutes and 49 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
crankMarket()catch block incrementedconsecutiveFailuresfor all errors, including transient RPC errors (429, timeout, socket reset, 502/503)consecutiveFailuresTransient error patterns detected
429,too many requests,rate limit,timeout,socket,econnrefused,econnreset,502,503,block height exceededTest plan
liquidation.tsfetchSlabWithRetry()🤖 Generated with Claude Code