update label check for dependabot action

[emmyoop]

Fix small bug where action to add changelog file never kicked off if the label was added before PR creation. It still worked if you added label after creation.

test to add label after PR creation

test to add label before PR creation

This should eventually be moved over to shared actions since we will need it across multiple repos.

Checklist

• I have read the contributing guide and understand what's expected of me
• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
• I have run changie new to create a changelog entry

[leahwicz]

In theory this would also kick-off if another label was added after the dependencies label, but nothing would happen since the changelog file would already exist, correct?

[emmyoop]

@leahwicz, correct. There's not a way I know of to only run if a specific label is added. So this will run, then it hits a check for if the changelog exists:

dbt-core/.github/workflows/dependency-changelog.yml

Lines 61 to 75 in efd1585

	- name: Check if changelog file exists already
	# if there's already a changelog entry, don't add another one!
	# https://github.com/marketplace/actions/paths-changes-filter
	# For each filter, it sets output variable named by the filter to the text:
	# 'true' - if any of changed files matches any of filter rules
	# 'false' - if none of changed files matches any of filter rules
	# also, returns:
	# `changes` - JSON array with names of all filters matching any of the changed files
	uses: dorny/paths-filter@v2
	id: changelog_check
	with:
	token: ${{ secrets.GITHUB_TOKEN }}
	filters: |
	exists:
	- added: '.changes/unreleased/**.yaml'

And should the pass on adding another one.

I could add another if to check if the action was labeled and the label was dependencies. IT would still trigger the workflow but would fail sooner. Something like this (syntax may be wrong):

jobs:
  dependency_changelog:
    if: |
      (${{ github.event == 'opened' }} && "contains(github.event.pull_request.labels.*.name, 'dependencies')")
      || (${{ github.event == 'labeled' }} && ${{ github.event.label.name == 'dependencies' }})

[leahwicz]

Yeah what you have is fine then since it does check for the changelog existing so the danger of the workflow running multiple times is accounted for. 🚢 it!