-
Notifications
You must be signed in to change notification settings - Fork 297
docs: Removed broken links from README.md
#818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs: Removed broken links from README.md
#818
Conversation
- Removed broken GitHub source code path references from Ontology, DataParser, and Util sections - Removed broken relative links (Build-from-Source-with-Maven, Installation, Run-from-Java-or-Scala, Run-from-a-JAR) - Added HTML comments documenting which links were removed
📝 WalkthroughWalkthroughThis pull request updates the README.md file to remove broken and outdated links, converting some bracketed namespace references to inline code formatting, and replacing non-functional links with updated resources. No functional code or public APIs are altered. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
🧰 Additional context used
🪛 LanguageTool
README.md
[uncategorized] ~7-~7: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...//dbpedia.slack.com/archives/C0L9MJFU7) slack channel within the DBpedia Slack worksp...
(ON_SKYPE)
[grammar] ~7-~7: Ensure spelling is correct
Context: ...a Slack workspace - the main point for [developement updates](https://github.com/dbpedia/ext...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.18.1)
README.md
130-130: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: long-running-tests
- GitHub Check: build
- GitHub Check: deploy
- GitHub Check: build
- GitHub Check: build
🔇 Additional comments (2)
README.md (2)
64-64: Documentation cleanup is appropriate.Removing the broken Data flow image reference with an HTML comment is a clean way to document the change. This aligns well with the PR objective.
79-84: Well-executed link removal and documentation.Converting the broken GitHub source code links to inline code formatting (backticks) for the namespace references and documenting the removal with HTML comments is a clear and maintainable approach. The namespace references are preserved in a readable format while broken links are cleanly removed.
|
It looks like the deploy job failed with a 403 Forbidden error because it's trying to upload artifacts from a forked repository. Since I don't have write access to the package registry, this step is expected to fail. @m1ci |
| **Documentation**: http://dev.dbpedia.org/Extraction <br/> | ||
| **Get in touch with DBpedia**: https://wiki.dbpedia.org/join/get-in-touch <br/> | ||
| **Slack**: join the [**#dev-team**](https://dbpedia.slack.com/archives/C0L9MJFU7) slack channel within the the [DBpedia Slack workspace](https://dbpedia-slack.herokuapp.com/) - the main point for [developement updates](https://github.com/dbpedia/extraction-framework/blob/master/.github/workflows/maven.yml) and discussions <br/> | ||
| **Slack**: join the [**#dev-team**](https://dbpedia.slack.com/archives/C0L9MJFU7) slack channel within the DBpedia Slack workspace - the main point for [developement updates](https://github.com/dbpedia/extraction-framework/blob/master/.github/workflows/maven.yml) and discussions <br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Slack**: join the [**#dev-team**](https://dbpedia.slack.com/archives/C0L9MJFU7) slack channel within the DBpedia Slack workspace - the main point for [developement updates](https://github.com/dbpedia/extraction-framework/blob/master/.github/workflows/maven.yml) and discussions <br/> | |
| **Slack**: join the [**#dev-team**](https://dbpedia.slack.com/archives/C0L9MJFU7) Slack channel within the DBpedia Slack workspace — the main point for [development updates](https://github.com/dbpedia/extraction-framework/blob/master/.github/workflows/maven.yml) and discussions <br/> |
| ### Core Module | ||
|
|
||
|  | ||
| <!-- Data flow image removed - original link was broken --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <!-- Data flow image removed - original link was broken --> | |
| <!-- original link to Data flow image was broken -- replaced by archive.org link --> | |
|  |
This appears to be inaccurate. A more accurate statement appears to be "Removed broken or outdated links" which is far less helpful, especially when functioning links can be found or constructed. I've suggested a few already. Perhaps you can revise the other "Removed broken" changes? |



Ontology,DataParser, andUtil sectionsBuild-from-Source-with-Maven,Installation,Run-from-Java-or-Scala,Run-from-a-JAR)solves issue #817