[DRAFT] Iterate on setup - config, CLI, and README updates#62
Draft
elliott-ruebush wants to merge 12 commits into
Draft
[DRAFT] Iterate on setup - config, CLI, and README updates#62elliott-ruebush wants to merge 12 commits into
elliott-ruebush wants to merge 12 commits into
Conversation
…ther than using global variable
elliott-ruebush
changed the title
elliott-ruebush
changed the title
Single-source install via pip install -e . (and .[dev] for pytest); drop requirements.txt files and ignore setuptools build/ output. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace utils.config with nps_active_space.config; bundle template.toml via setuptools package-data. Co-authored-by: Cursor <cursoragent@cursor.com>
Update imports from the removed utils.config module across CLIs and legacy code. Co-authored-by: Cursor <cursoragent@cursor.com>
Copies the bundled template into the user config directory with -e naming. Co-authored-by: Cursor <cursoragent@cursor.com>
Mirror config layout under tests/config; remove obsolete setup.cfg. Co-authored-by: Cursor <cursoragent@cursor.com>
Update root and package READMEs for pyproject deps, nps-init-config, and config layout. Co-authored-by: Cursor <cursoragent@cursor.com>
elliott-ruebush
commented
May 30, 2026
|
|
||
| The toolkit also requires basic sound source and weather profile data to operate. The provided (`.data`) are a widely applicable example: a fixed-wing propeller aircraft source and a standard "acoustician's atmosphere" with dry adiabatic lapse conditions. The toolkit may be run using alternative, custom sound sources or weather profiles. | ||
|
|
||
| ### Data and File Directory Setup |
Collaborator
Author
There was a problem hiding this comment.
Moved this section to config/README.md since I felt like it fit in well with a more detailed overview of the other setup you would do to run active space workflows
elliott-ruebush
force-pushed
the
feature/iterate_on_setup
branch
2 times, most recently
from
660e289 to
3a27be4
Compare
elliott-ruebush
force-pushed
the
feature/iterate_on_setup
branch
from
3a27be4 to
4a1eed4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacks on #63. Pydantic config + dependency injection,
nps-*CLI entry points, TOML template, subprocess fixes, and tests.Recent commits on this branch:
pyproject.toml(pip install -e ./.[dev]).requirements.txtremoved. This allows you to pull in your dependencies via just pip installing rather than also having to install the requirements explicitly. The goal is that this gets us closer to a state where you can just pip install NPS-ActiveSpace and run it (assuming you have GDAL and a binary for NMSIM/AAM)nps_active_space.configreplacesutils.config— Pydantic models for enforcing config structure, TOML, proper PythonPathobjectsnps-init-config -e <name>creates a new config file{name}.tomlunder~/.nps_active_space(orNPS_ACTIVE_SPACE_CONFIG_DIRenvironment variable dir). Pipeline scripts importnps_active_space.config.tests/config/unit tests; root and package READMEs updated to reflect changes/try to clarify structure in some casesTest plan
fix/src_layout)pytest(includestests/config/)pip install -e ".[dev]"thennps-init-config -e TESTandnps-ground-truthing --help