Skip to content

Minor logging update to report accurate dropped numbers #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sssangha wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Minor logging update to report accurate dropped numbers #791

sssangha wants to merge 6 commits into from

Conversation

@sssangha
Copy link
Collaborator

@sssangha sssangha commented Dec 16, 2025 •
edited
Loading

Updated warning message to reflect the number of dropped stations due to NaN values.

Also adjust logging lines for raiderCombine.py workflow such that every message is not a warning.

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sssangha
Minor logging update to report accurate dropped numbers
830d3b9 
Removed redundant drop_duplicates call and updated warning message to reflect the number of dropped stations due to NaN values.
@sssangha
Change logger from warning to info level
bf675a5
@sssangha
Update CHANGELOG with recent changes
d092f06 
Updated CHANGELOG to include recent changes and fixes.
@sssangha sssangha marked this pull request as ready for review December 16, 2025 19:44
@sssangha
Enhance logging for flagged stations in processDelayFiles
36ca49b 
Added logging warnings for flagged stations with invalid dates, insufficient epochs, and negative sigma values.
@sssangha
Fix formatting in warning message for dropped stations
a68f24d
@sssangha
Refactor logging messages to use % formatting
078330d 
Refactor logging messages to use % formatting instead of f-strings for better performance and compatibility.
@sssangha sssangha requested a review from jlmaurer December 17, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlmaurer jlmaurer Awaiting requested review from jlmaurer

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sssangha