Skip to content

Conversation

@nate-kean
Copy link
Contributor

@nate-kean nate-kean commented Sep 15, 2025

Description

Adds a line that transforms all bounding boxes the GeocodedFile AOI receives to EPSG:4326.

Motivation and Context

Rest of the code is not properly set up to handle GeocodedFile AOIs that are not in EPSG:4326, which causes problems with EPSG:32617 interferograms like from ASF On Demand. I lack the time to fix this properly, but I did end up doing this much so that RAiDER would work with my code for the gemlab ASF On Demand notebook jlmaurer/gemlab#11. I offer what I have in case you might want to accept it and/or use it as a jumping-off point for a more in-depth solution.

In the case when the user inputs a geocoded file with projection other than EPSG:4326, this change fixes a crash, at the cost of more transformations in this code path, and any precision errors or other drawbacks that may come with it. A more thoughtful solution may be able to avoid doing a conversion here.
In all other cases (other projections, other input AOI types), nothing is changed/affected.

How Has This Been Tested?

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dbekaert
Copy link
Owner

dbekaert commented Sep 15, 2025 via email

Rest of the code is not properly set up to handle GeocodedFile AOIs that are not in EPSG:4326, which causes problems with EPSG:32617 interferograms from ASF On Demand. I personally lack the time to fix this properly, but I did end up doing this much so that RAiDER would work with my code for the gemlab ASF On Demand notebook jlmaurer/gemlab#11.

In the case when the user inputs a geocoded file with projection other than EPSG:4326, this change fixes a crash, at the cost of probably more projection conversion artifacts than necessary from a more in-depth solution. In all other cases (other projections, other input AOI types), nothing is changed/affected.
@nate-kean nate-kean force-pushed the fix-geocoded-file-other-proj branch from 6ba0915 to cacab09 Compare September 15, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants