Skip to content

Conversation

@nate-kean
Copy link
Contributor

@nate-kean nate-kean commented Aug 22, 2025

Description

Adds Python 3.13 as a tested version in the CircleCI configuration, and introduces some small changes to the following tests to make them work in Python 3.13:

  • test_GUNW_hyp3_metadata_update
  • test_GUNW_hyp3_metadata_update_different_prefix
  • test_cube_timemean
  • test_cube_weighting

Motivation and Context

test_GUNW_hyp3_metadata_update series: updated gunw_schema.json to the version of the JSON Schema spec that jsonschema 4+ uses. jsonschema upgraded from ==3.2.0 to >=4 to make it compatible with Python 3.13.

test_cube_ series: Was also failing in lower Python versions. I cherry-picked the MERRA2-relevant bit from #752, and the issue fixed itself. The code for interacting with the dataset seemed invalid for one returned from pydap, but it fit perfectly with one from xarray.

I also included a refactor to test_temporal_interpolate.py that helped me debug this. calcDelays is now called directly instead of through subprocess.run, so the debugger will break at exceptions that occur within it.

How Has This Been Tested?

Tests now all pass in CircleCI on all our supported Python versions, including Python 3.13. I can confirm that all tests pass locally on Python 3.13, as well.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

nate-kean added a commit to nate-kean/RAiDER that referenced this pull request Aug 22, 2025
nate-kean added a commit to nate-kean/RAiDER that referenced this pull request Aug 25, 2025
commit 593e717
Merge: 49d08bc b32655c
Author: Nate Kean <natekean65535@gmail.com>
Date:   Sat Aug 23 21:49:06 2025 -0500

    Merge branch 'dbekaert:dev' into test-fixes

commit 49d08bc
Merge: 5e285b5 df9e299
Author: Nate Kean <natekean65535@gmail.com>
Date:   Fri Aug 22 11:28:56 2025 -0500

    Merge branch 'test-fixes' of https://github.com/nate-kean/RAiDER into test-fixes

commit 5e285b5
Author: Nate Kean <natekean65535@gmail.com>
Date:   Fri Aug 22 11:28:07 2025 -0500

    Update CHANGELOG.md for dbekaert#761

commit ef65d93
Author: Nate Kean <natekean65535@gmail.com>
Date:   Thu Aug 21 21:28:11 2025 -0500

    Fix test_GUNW_hyp3_metadata_update: fix invalid gunw_schema.json

commit 0275c85
Author: Nate Kean <natekean65535@gmail.com>
Date:   Thu Aug 21 20:36:44 2025 -0500

    Fix test_temporal_interpolate.py: use xarray for MERRA2._fetch()

commit df9e299
Author: Nate Kean <natekean65535@gmail.com>
Date:   Thu Aug 21 21:28:11 2025 -0500

    Fix test_GUNW_hyp3_metadata_update: fix invalid gunw_schema.json

commit 0e2c99d
Author: Nate Kean <natekean65535@gmail.com>
Date:   Thu Aug 21 20:36:44 2025 -0500

    Fix test_temporal_interpolate.py: use xarray for MERRA2._fetch()
nate-kean added a commit to nate-kean/RAiDER that referenced this pull request Aug 26, 2025
@nate-kean nate-kean marked this pull request as draft August 26, 2025 17:56
@nate-kean nate-kean marked this pull request as ready for review August 28, 2025 18:50
@jlmaurer jlmaurer requested a review from cmarshak August 28, 2025 18:56
@nate-kean nate-kean changed the title Test fixes Add Python 3.13 compatibility Aug 28, 2025
Copy link
Collaborator

@jlmaurer jlmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @cmarshak you may want to take a quick look before this gets merged. Tests all pass so I assume this is consistent with existing GUNW file structure.

@jlmaurer jlmaurer merged commit 3d91448 into dbekaert:dev Aug 28, 2025
9 checks passed
@jlmaurer jlmaurer mentioned this pull request Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants