-
Notifications
You must be signed in to change notification settings - Fork 40
Add Python 3.13 compatibility #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-kean
added a commit
to nate-kean/RAiDER
that referenced
this pull request
Aug 22, 2025
nate-kean
added a commit
to nate-kean/RAiDER
that referenced
this pull request
Aug 25, 2025
commit 593e717 Merge: 49d08bc b32655c Author: Nate Kean <natekean65535@gmail.com> Date: Sat Aug 23 21:49:06 2025 -0500 Merge branch 'dbekaert:dev' into test-fixes commit 49d08bc Merge: 5e285b5 df9e299 Author: Nate Kean <natekean65535@gmail.com> Date: Fri Aug 22 11:28:56 2025 -0500 Merge branch 'test-fixes' of https://github.com/nate-kean/RAiDER into test-fixes commit 5e285b5 Author: Nate Kean <natekean65535@gmail.com> Date: Fri Aug 22 11:28:07 2025 -0500 Update CHANGELOG.md for dbekaert#761 commit ef65d93 Author: Nate Kean <natekean65535@gmail.com> Date: Thu Aug 21 21:28:11 2025 -0500 Fix test_GUNW_hyp3_metadata_update: fix invalid gunw_schema.json commit 0275c85 Author: Nate Kean <natekean65535@gmail.com> Date: Thu Aug 21 20:36:44 2025 -0500 Fix test_temporal_interpolate.py: use xarray for MERRA2._fetch() commit df9e299 Author: Nate Kean <natekean65535@gmail.com> Date: Thu Aug 21 21:28:11 2025 -0500 Fix test_GUNW_hyp3_metadata_update: fix invalid gunw_schema.json commit 0e2c99d Author: Nate Kean <natekean65535@gmail.com> Date: Thu Aug 21 20:36:44 2025 -0500 Fix test_temporal_interpolate.py: use xarray for MERRA2._fetch()
nate-kean
added a commit
to nate-kean/RAiDER
that referenced
this pull request
Aug 26, 2025
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
- Reduce data duplication: Pull Python versions from .circleci/config.yaml instead of hardcoding them again - Improve logging - Add comments, documentation
jlmaurer
approved these changes
Aug 28, 2025
Collaborator
jlmaurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @cmarshak you may want to take a quick look before this gets merged. Tests all pass so I assume this is consistent with existing GUNW file structure.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Python 3.13 as a tested version in the CircleCI configuration, and introduces some small changes to the following tests to make them work in Python 3.13:
test_GUNW_hyp3_metadata_updatetest_GUNW_hyp3_metadata_update_different_prefixtest_cube_timemeantest_cube_weightingMotivation and Context
test_GUNW_hyp3_metadata_updateseries: updatedgunw_schema.jsonto the version of the JSON Schema spec thatjsonschema4+ uses.jsonschemaupgraded from==3.2.0to>=4to make it compatible with Python 3.13.test_cube_series: Was also failing in lower Python versions. I cherry-picked the MERRA2-relevant bit from #752, and the issue fixed itself. The code for interacting with the dataset seemed invalid for one returned frompydap, but it fit perfectly with one fromxarray.I also included a refactor to
test_temporal_interpolate.pythat helped me debug this.calcDelaysis now called directly instead of throughsubprocess.run, so the debugger will break at exceptions that occur within it.How Has This Been Tested?
Tests now all pass in CircleCI on all our supported Python versions, including Python 3.13. I can confirm that all tests pass locally on Python 3.13, as well.
Type of change
Checklist: