Fix GMAO #756
Draft
Fix GMAO #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `utilFcns.write_weather_vars_to_ds`: annotate number of dimensions - types: Add generic version of the numpy array helper types so you can annotate an array of booleans as `Array1D[np.bool]` - Add type annotations to `models.hrrr.get_bounds_indices`
Add tests: - Reintroduce test_scenario_1 - Parametrize test_scenario_4 for all models - Finish plumbing out dir arg to AOI classes - The test in test_HRRR_ztd.py had to be renamed to prevent a name collision Rename warpedDEM.dem to .rdr, fix test_scenario_1: There are actually height files in RADAR coordinates, not DEMs in satellite coordinates. "A DEM that has been warped into a height file". This makes that more clear by giving them the file extension typically used for files in RADAR coordinates. Remove NCMR support, cleanup Fix type annotation
Incredibly perplexing that this was not failing long ago with an error saying that .bbox does not exist, because it shouldn't. There is nowhere in the problem that sets `.bbox` on a WeatherModel object except in this one line in this function. That one line is the only possibly place it could be set, and yet I observed weather model objects _indeed_ having a .bbox property, and it _wasn't_ (-180, -90, 180, 90). No idea what to make of that. The program is haunted. But this change makes this function use the property I believe it intended to use.
A weird trick allows you to do this on standard file servers (like portal.nccs.nasa.gov). Without this, the file server has to have extra features installed (a THREADS server). Found here: pydata/xarray#3653 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes code in the GMAO class to allow
GMAO.load()to run successfully/without exceptions again.Motivation and Context
Resolves #755.
How Has This Been Tested?
Makes GMAO pass for the
test_scenario_1end-to-end test introduced in #751.Type of change
Checklist: